Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary conversion in mutable state #977

Closed
wxing1292 opened this issue Nov 11, 2020 · 0 comments · Fixed by #1409
Closed

Remove unnecessary conversion in mutable state #977

wxing1292 opened this issue Nov 11, 2020 · 0 comments · Fixed by #1409
Labels
enhancement New feature or request refactoring

Comments

@wxing1292
Copy link
Contributor

Is your feature request related to a problem? Please describe.

UpsertActivityInfos: convertUpdateActivityInfos(e.updateActivityInfos),
DeleteActivityInfos: convertDeleteActivityInfos(e.deleteActivityInfos),
UpsertTimerInfos: convertUpdateTimerInfos(e.updateTimerInfos),
DeleteTimerInfos: convertDeleteTimerInfos(e.deleteTimerInfos),
UpsertChildExecutionInfos: convertUpdateChildExecutionInfos(e.updateChildExecutionInfos),
DeleteChildExecutionInfo: e.deleteChildExecutionInfo,
UpsertRequestCancelInfos: convertUpdateRequestCancelInfos(e.updateRequestCancelInfos),
DeleteRequestCancelInfo: e.deleteRequestCancelInfo,
UpsertSignalInfos: convertUpdateSignalInfos(e.updateSignalInfos),
DeleteSignalInfo: e.deleteSignalInfo,
UpsertSignalRequestedIDs: convertStringSetToSlice(e.updateSignalRequestedIDs),
DeleteSignalRequestedID: e.deleteSignalRequestedID,
NewBufferedEvents: e.updateBufferedEvents,
ClearBufferedEvents: e.clearBufferedEvents,

Above conversions are unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant