Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce data type conversion between mutable state & persistence #1409

Merged
merged 2 commits into from Mar 26, 2021

Conversation

wxing1292
Copy link
Contributor

What changed?

  • Remove unnecessary conversion between slice and map for the following type:
    • activity
    • timer
    • child workflow
    • request cancel
    • signal

Why?
Some data type conversions are unnecessary
Close #977

How did you test it?
Existing test

Potential risks
N/A

Is hotfix candidate?
No

@wxing1292 wxing1292 requested review from alexshtin and a team March 26, 2021 19:08
…stence

* Remove unnecessary conversion between slice and map for the following type:
  * activity
  * timer
  * child workflow
  * request cancel
  * signal
@wxing1292 wxing1292 enabled auto-merge (squash) March 26, 2021 20:16
@wxing1292 wxing1292 disabled auto-merge March 26, 2021 20:23
@wxing1292 wxing1292 enabled auto-merge (squash) March 26, 2021 20:23
@wxing1292 wxing1292 merged commit 9176647 into temporalio:master Mar 26, 2021
@wxing1292 wxing1292 deleted the less-conversion branch March 26, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary conversion in mutable state
2 participants