Accept empty Kafka config when visibility queue is set to internal #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Jan 28, 2021
wxing1292
reviewed
Jan 28, 2021
wxing1292
approved these changes
Jan 28, 2021
alexshtin
changed the title
alexshtin
added a commit
that referenced
this pull request
Jan 29, 2021
|
Hey. Thanks for the update. to in values.yaml? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Accept empty Kafka config when visibility queue is set to
internal.Why?
Kafka is about to be deprecated and with current visibility queue default Kafka is not needed.
How did you test it?
Run locally w/o kafka config.
Potential risks
No risks.