Perf optimize NDC RPC replication, reducing DB calls #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
changed the title
wxing1292
force-pushed
the
perf-rpc-replication
branch
3 times, most recently
from
44cf2ea
to
6215955
Compare
* Rename ReadLevel to MinTaskID, MaxReadLevel to MaxTaskID * Add hint in replication task source reducing unnecessary DB read * Add periodical sanity check in replication task source in case of timeout err * Treat last replication task ID vs replication task pagination ID differently
wxing1292
force-pushed
the
perf-rpc-replication
branch
from
6215955
to
ef17ec8
Compare
alexshtin
approved these changes
Mar 24, 2021
alexshtin
reviewed
Mar 24, 2021
| fetchTasksBatchSize int | ||
| pageSize int | ||
|
|
||
| sync.Mutex |
There was a problem hiding this comment.
I think it is good practice to place embedded types on top but in this case, I believe it worth to be a named field maxTaskIDMutex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Reduce unnecessary DB read for replication tasks
Close #1354
How did you test it?
New tests, local run, CICD
Potential risks
N/A
Is hotfix candidate?
No