Performance optimization for start child workflow task #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Release mutable state lock earlier since start child workflow workflow task does not require locking
alexshtin
reviewed
Mar 24, 2021
| // NOTE: do not access anything related mutable state after this lock release | ||
| // release the context lock since we no longer need mutable state builder and | ||
| // the rest of logic is making RPC call, which takes time. | ||
| release(nil) |
There was a problem hiding this comment.
It is safe to call release multiply times, right?
There was a problem hiding this comment.
yes, release function within has an atomic int for status tracking:
https://github.com/temporalio/temporal/blob/v1.8.0/service/history/historyCache.go#L262
alexshtin
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
RPC call to create the first workflow task of child workflow does not require locking
How did you test it?
Existing tests
Potential risks
N/A
Is hotfix candidate?
No