Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reserved search attribute name validation logic #1398

Merged

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented Mar 23, 2021

What changed?
Fix reserved search attribute name validation logic.
Removed HistoryLength and Encoding from indexed template.

Why?
Some search attribute names were not checked as system.

How did you test it?
Run canary locally + existing tests.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested a review from a team March 23, 2021 23:55
@alexshtin alexshtin enabled auto-merge (squash) March 26, 2021 20:43
@alexshtin alexshtin merged commit 46920a1 into temporalio:master Mar 26, 2021
@alexshtin alexshtin deleted the feature/fix-internal-search-attributes branch March 29, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants