Fix metrics namespace tagging issue for matching & history service #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix namespace name metrics extraction issue for matching & history service Previously, the namespace attribute extraction only works for frontend service (request comes with namespace name). Internal request only contains namespace ID, which were not processed correctly
alexshtin
approved these changes
Mar 29, 2021
wxing1292
added a commit
that referenced
this pull request
Mar 29, 2021
…1414) * Fix namespace name metrics extraction issue for matching & history service Previously, the namespace attribute extraction only works for frontend service (request comes with namespace name). Internal request only contains namespace ID, which were not processed correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Previously, the namespace attribute extraction only works for frontend service (request comes with namespace name).
Internal request only contains namespace ID, which were not processed correctly
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
Yes