Begin the migration of executions table operation using atomic counter #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add db version attribute to executions table for better CAS guarantee * 1.9.x will by default use existing next event ID for CAS, but will also support the new DB version CAS * 1.10.x will by default use DB version CAS
alexshtin
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Last event ID is not enough for CAS operation protection: e.g. activity heartbeat will not generate new history event, meaning last event ID will remain the same during the CAS to DB.
The newly introduced DB version will be increased by 1 each time execution table is updated (update to mutable state record).
Close #435
How did you test it?
Existing tests, randomized tests, CICD
Potential risks
Some low level persistence interfaces are changed.
Is hotfix candidate?
No