Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port history builder into dedicated package #1421

Merged
merged 2 commits into from Mar 31, 2021
Merged

Port history builder into dedicated package #1421

merged 2 commits into from Mar 31, 2021

Conversation

wxing1292
Copy link
Contributor

What changed?

  • New history builder completed decoupled from mutable state
  • New logic allowing buffering multiple batches
  • Existing logic remains as is

Why?
Prerequisite PR for #1358 and event chaining
Improve code maintainability by decoupling from mutable state

How did you test it?
Logic is not used

Potential risks
N/A

Is hotfix candidate?
No

@wxing1292
Port history builder into dedicated package
4fcacaf 
* Existing logic remains as is
* New history builder completed seperated from mutable state
@wxing1292 wxing1292 requested review from alexshtin and a team March 31, 2021 19:21
alexshtin
alexshtin approved these changes Mar 31, 2021
View reviewed changes
service/history/executions/history_builder.go Outdated Show resolved Hide resolved
@wxing1292 wxing1292 enabled auto-merge (squash) March 31, 2021 20:50
@wxing1292 wxing1292 merged commit 2947301 into temporalio:master Mar 31, 2021
@wxing1292 wxing1292 deleted the history-builder branch March 31, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wxing1292 @alexshtin