Refactor cluster metadata for search attributes #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Mar 31, 2021
| @@ -108,8 +108,8 @@ func NewMetadata( | |||
| } | |||
| versionToClusterName[info.InitialFailoverVersion] = clusterName | |||
|
|
|||
| if info.Enabled && (len(info.RPCName) == 0 || len(info.RPCAddress) == 0) { | |||
| panic(fmt.Sprintf("Cluster %v: rpc name / address is empty", clusterName)) | |||
| if info.Enabled && info.RPCAddress == "" { | |||
There was a problem hiding this comment.
yes, there was a TODO for it. I resolved it.
wxing1292
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor cluster metadata for search attributes changes (upcoming).
Why?
This change is required to implement new search attributes behaviour.
Plus some clean up of server startup code.
How did you test it?
Existing tests + local run.
Potential risks
No risks.
Is hotfix candidate?
N/A