Remove params field from service and handler objects #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
changed the title
alexshtin
commented
Apr 1, 2021
Comment on lines
+74
to
+76
| ESConfig *config.Elasticsearch | ||
| ESClient esclient.Client | ||
| DynamicConfigClient dynamicconfig.Client |
There was a problem hiding this comment.
This will be removed soon too.
wxing1292
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove
paramsfield from service and handler objects.Move some service and handler initialization logic to constructor from
Start()method.Why?
paramsobject is to pass params to constructors but not to be stored as a field inside object itself.How did you test it?
Build, run current tests, run canary locally.
Potential risks
No risks.
Is hotfix candidate?
No.