Port mutable state events buffering functionality to new history builder #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
force-pushed
the
events-reorder
branch
2 times, most recently
from
f6cb5c4
to
11b22f3
Compare
* Port mutable state events buffering functionality to new history builder * Port mutable state events flushing funtionality to new history builder * Port mutable state buffer events ID wire logic to new history builder * Add necessary UT
wxing1292
force-pushed
the
events-reorder
branch
2 times, most recently
from
c0043ea
to
01c9415
Compare
wxing1292
force-pushed
the
events-reorder
branch
from
01c9415
to
e6dc97d
Compare
alexshtin
approved these changes
Apr 5, 2021
| // TODO historyEvent.TaskId | ||
| historyEvent.EventId = b.nextEventID | ||
| historyEvent.TaskId = common.EmptyEventTaskID | ||
| b.nextEventID += 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Move events buffer / reordering logic into dedicated place && more UT
Easier to implement events chaining
How did you test it?
New tests
Potential risks
No, code not used yet
Is hotfix candidate?
No