Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prev transaction ID attribute to history node table for events chaining #1435

Merged
merged 4 commits into from Apr 6, 2021

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Apr 6, 2021

What changed?

  • New last_history_node_txn_id within execution info tracking the last valid history node
  • New prev_txn_id within history node table tracking previous valid history node record

Why?
Chaining events provides an ability for Temporal server to trim history events, during DB inconsistency.

How did you test it?
UT & Manual tests
Next PR will add ability to validate and trim stale events.

Potential risks
N/A

Is hotfix candidate?
No

@wxing1292 wxing1292 requested a review from alexshtin April 6, 2021 00:52
* New prev_txn_id within histroy node table tracking previous valid history node record
* New validation logic trimming stale history node record in case DB is not consist
@wxing1292 wxing1292 marked this pull request as ready for review April 6, 2021 18:44
@wxing1292 wxing1292 requested a review from a team April 6, 2021 18:44
@wxing1292 wxing1292 force-pushed the evens-chaining branch 3 times, most recently from 1d72fe6 to aa97be3 Compare April 6, 2021 21:20
@wxing1292 wxing1292 merged commit 394542b into temporalio:master Apr 6, 2021
@wxing1292 wxing1292 deleted the evens-chaining branch April 6, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants