Fail workflow if search attributes size exceed limit #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Apr 7, 2021
wxing1292
reviewed
Apr 7, 2021
wxing1292
approved these changes
Apr 7, 2021
alexshtin
force-pushed
the
feature/sa-size-fail-wf
branch
from
b5a387f
to
d2981db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fail workflow if search attributes size exceed limit.
Split single search attributes validator into two:
Why?
First validator works as before: it fails workflow task and therefore leads to retries (until Workflow code is fixed or search attribute is registered).
Second validator now fails Workflow right away to prevent server overload due to exceeded size of search attributes values.
How did you test it?
Run existing tests.
Potential risks
Total size limit now include attributes names and metadata size, so if total size was very close to the limit before it might start fail workflow now. Which is very unlikely though, because default total size limit is 40K.
Is hotfix candidate?
No.