Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Cassandra iter nil check #1440

Merged
merged 2 commits into from Apr 7, 2021
Merged

Remove unnecessary Cassandra iter nil check #1440

merged 2 commits into from Apr 7, 2021

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Apr 7, 2021 •
edited by alexshtin

What changed?

  • Remove unnecessary Cassandra iter nil check.

Why?
gocql will panic if iter is nil:
https://github.com/gocql/gocql/blob/80ab1e13e30998eef848d9de0bfe4a0f1403b31c/session.go#L486

How did you test it?
N/A

Potential risks
N/A

Is hotfix candidate?
No

@wxing1292 wxing1292 requested review from alexshtin and a team April 7, 2021 18:37
@wxing1292 wxing1292 enabled auto-merge (squash) April 7, 2021 18:38
@wxing1292 wxing1292 merged commit a1a4de2 into temporalio:master Apr 7, 2021
@wxing1292 wxing1292 deleted the remove-unncessary-check branch April 7, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wxing1292 @alexshtin