Remove TTL from open_executions Cassandra visibility table #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Apr 13, 2021
Comment on lines
+405
to
+407
| if _, notFound := err.(*serviceerror.NotFound); !notFound { | ||
| return err | ||
| } |
There was a problem hiding this comment.
the task processing logic will treat not found as nil
There was a problem hiding this comment.
This is why it is not returned.
wxing1292
reviewed
Apr 13, 2021
| retentionSeconds = int64(timestamp.DurationFromDays(namespaceEntry.GetRetentionDays(workflowID)).Seconds()) | ||
| var retention *time.Duration | ||
| namespace := defaultNamespace | ||
| recordWorkflowClose := true |
There was a problem hiding this comment.
should the sampling logic be handled by the visibility sampling store?
There was a problem hiding this comment.
I was also surprised to see it there but as soon as I am going to replace it with throttling soon, will just leave it there for now.
wxing1292
approved these changes
Apr 13, 2021
alexshtin
added a commit
that referenced
this pull request
Apr 15, 2021
alexshtin
added a commit
that referenced
this pull request
Apr 15, 2021
alexshtin
added a commit
that referenced
this pull request
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove TTL from
open_executionsCassandra visibility table.Why?
Previously TTL was set to workflow timeout as an extra protection in case of close workflow execution task lost. Also there was a bug in this protection which set this TTL to 1 day in case of
nil(unlimited timeout). This protection is not needed with new visibility queue.How did you test it?
Current tests.
Potential risks
No risks.
Is hotfix candidate?
Yes.