Perf optimize mutable state DB operation #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduce unnecessary update to DB if deletion is specified * Activity * Timer * Cancel External * Signal External * Child workflow * Rename newMutableStateBuilderWithVersionHistories to newMutableStateBuilder * Combine previous newMutableStateBuilder and Load to newMutableStateBuilderFromDB
alexshtin
approved these changes
Apr 15, 2021
alexshtin
reviewed
Apr 15, 2021
| } | ||
|
|
||
| // TODO unify Load and StartTransaction | ||
| func (e *mutableStateBuilder) Load( | ||
| state *persistencespb.WorkflowMutableState, |
There was a problem hiding this comment.
Probably worth to rename state to mutableState or ms here. Or leave it for the future refactorings.
There was a problem hiding this comment.
i have one PR to be send out in few minutes, i can address it there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Remove unnecessary DB operation, e.g. update one activity and within the same transaction delete it.
Close #1399
How did you test it?
Existing tests
Potential risks
N/A
Is hotfix candidate?
No