Fix periodic checks for expiring certificates #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed a couple of bugs in the logic of checking for expiring certificates.
Add configuration in tests to actually test periodic checks.
Why?
The feature of periodic checks is currently broken.
Configuration for it was not added to tests, and that allowed the bugs to "pass" tests originally.
How did you test it?
Added missing configuration to tests to cause the tests to fail.
With the fix they are passing.
Also, manually tested that the metrics for certificates approaching expiration do get emitted by the server.
Potential risks
I don't see any. The checks are enable via configuration, and they were broken before this fix.
Is hotfix candidate?
Potentially.