Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing error check for schema version check #1471

Merged
merged 1 commit into from Apr 17, 2021
Merged

Add missing error check for schema version check #1471

merged 1 commit into from Apr 17, 2021

Conversation

wxing1292
Copy link
Contributor

What changed?

  • Add missing error check for schema version check

Why?
Missing error check

How did you test it?
Manual

Potential risks
N/A

Is hotfix candidate?
No

@wxing1292 wxing1292 requested review from alexshtin and a team April 17, 2021 03:44
@wxing1292 wxing1292 enabled auto-merge (squash) April 17, 2021 03:44
@wxing1292 wxing1292 merged commit cb02a52 into temporalio:master Apr 17, 2021
@wxing1292 wxing1292 deleted the missing-error-check branch April 17, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underrun underrun underrun approved these changes

@mattkim mattkim mattkim approved these changes

@alexshtin alexshtin Awaiting requested review from alexshtin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wxing1292 @underrun @mattkim