Introduce SQL_TLS_ENABLED env var to allow enabling TLS for SQL datastores #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Apr 18, 2021
| @@ -64,6 +64,8 @@ persistence: | |||
| maxConns: {{ default .Env.SQL_MAX_CONNS "20" }} | |||
| maxIdleConns: {{ default .Env.SQL_MAX_IDLE_CONNS "20" }} | |||
| maxConnLifetime: {{ default .Env.SQL_MAX_CONN_TIME "1h" }} | |||
| tls: | |||
| enabled: {{ default .Env.SQL_TLS_ENABLED "false" }} | |||
There was a problem hiding this comment.
can you also add caFile, certFile, keyFile & enableHostVerification?
ref:
https://github.com/temporalio/temporal/blob/master/docker/config_template.yaml#L26-LL28
https://github.com/temporalio/temporal/blob/master/docker/config_template.yaml#L32
There was a problem hiding this comment.
Done. I've also added the ability to specify TLS.ServerName through {CASSANDRA,SQL}_HOST_NAME env vars.
aromanovich
force-pushed
the
sql-tls-enabled
branch
from
bb6ec62
to
7948904
Compare
wxing1292
approved these changes
Apr 20, 2021
|
Thank you, @aromanovich! |
aromanovich
added a commit
to aromanovich/temporal
that referenced
this pull request
Apr 20, 2021
…tores (temporalio#1473) * Introduce SQL_* env vars to allow configuring TLS for SQL databases
|
Almost a year after we found out that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
config_template.yaml now supports enabling TLS for SQL databases through the
SQL_TLS_ENABLEDenv var.