Add logging for attempted and successful TLS connections to server #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermanu
reviewed
Apr 23, 2021
common/auth/tlsConfigHelper.go
Outdated
| ) *tls.Config { | ||
| c := NewEmptyTLSConfig() | ||
| c.ClientAuth = clientAuth | ||
| c.Certificates = certificates | ||
| c.ClientCAs = clientCAs | ||
| c.VerifyConnection = func(state tls.ConnectionState) error { | ||
| logger.Info("successfully established incoming TLS connection", tag.HostID(state.ServerName)) |
There was a problem hiding this comment.
Do we think this should be Debug level log to avoid spamming if there are a lot of incoming connections? Or is Info fine?
mastermanu
reviewed
Apr 23, 2021
| if perHostCertProviderMap != nil { | ||
| perHostCertProvider, hostClientAuthRequired, err := perHostCertProviderMap.GetCertProvider(c.ServerName) | ||
| if err != nil { | ||
| logger.Warn("cannot find a per-host provider for attempted incoming TLS connection", |
There was a problem hiding this comment.
Do we want to log the error here?
mastermanu
reviewed
Apr 23, 2021
mastermanu
reviewed
Apr 23, 2021
mastermanu
reviewed
Apr 23, 2021
mastermanu
requested changes
Apr 23, 2021
mastermanu
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added logging of attempted and successfully established TLS connections to server
Why?
To have records in the log of all attempted TLS connections to server and remote IP addresses of parties trying to connect.
How did you test it?
Unit tests.
Potential risks
No risks.
Is hotfix candidate?
No.