Skip visibility database validation if advanced visibility is enabled #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Apr 27, 2021
wxing1292
approved these changes
Apr 27, 2021
alexshtin
force-pushed
the
feature/fix-visibility-config-validation
branch
from
de811f2
to
f7c27f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Skip visibility database validation if advanced visibility is enabled.
Why?
If advanced visibility is enabled (
system.advancedVisibilityWritingModeisonin dynamic config) there is no need to validate visibility database configuration because it is not used. This allows to remove visibility database configuration from static config in case if advanced visibility is enabled. Closes #1280.How did you test it?
Run server locally with and without ES.
Potential risks
If visibility database is not configured and
system.advancedVisibilityWritingModeis changed tooffwhile server is running, it will lead to unpredictable behaviour.Is hotfix candidate?
No.