Refactor Dockerfile and scripts #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/refactor-dockerfile
branch
from
6cbcf1b
to
899f2bf
Compare
wxing1292
reviewed
Apr 28, 2021
wxing1292
approved these changes
Apr 28, 2021
alexshtin
force-pushed
the
feature/refactor-dockerfile
branch
from
899f2bf
to
a933527
Compare
underrun
reviewed
Apr 28, 2021
docker/auto-setup.sh
Outdated
|
|
||
| wait_for_cassandra() { | ||
| # TODO (alex): Remove exports | ||
| export CASSANDRA_USER=$CASSANDRA_USER |
There was a problem hiding this comment.
if you are exporting a variable that's already set you can just do
export CASSANDRA_USER
export CASSANDRA_PORT
etc
There was a problem hiding this comment.
I would leave it as is for now and refactor later as part of TODO above.
docker/auto-setup.sh
Outdated
| export CASSANDRA_TLS_KEY=$CASSANDRA_CERT_KEY | ||
| export CASSANDRA_TLS_CA=$CASSANDRA_CA | ||
|
|
||
| { export CASSANDRA_PASSWORD=$CASSANDRA_PASSWORD; } 2> /dev/null |
There was a problem hiding this comment.
this is to hide output? also just bare export CASSANDRA_PASSWORD
This was referenced May 6, 2021
alexshtin
force-pushed
the
feature/refactor-dockerfile
branch
from
06ad5d0
to
d9b72d8
Compare
underrun
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor Dockerfile and scripts.
Why?
entrypoint.sh->auto-setup.sh(optional),setup-develop.sh(optional),start-temporal.sh->exec temporal-server./etc/temporalinstead of the root.shellcheck.How did you test it?
Build locally and run with docker-compose.
Potential risks
RFenv was renamed toCASSANDRA_REPLICATION_FACTOR.Is hotfix candidate?
No.