Merge serialization methods into new Serializer #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wxing1292
approved these changes
May 25, 2021
yiminc
force-pushed
the
payload_serializer_v2
branch
from
c1b410f
to
2840cf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new interface Serializer that contains all methods defined in PayloadSerializer and methods defined in common/persistence/seraliazation/blob.go.
Why?
We want to move all seralization/deseralization logic to the layer above persistence. The data layer will then use this new interface to do seralization/deseralization, and persistence layer will only deal with DataBlob. This will enforce abstract layering. Follow up PRs will convert existing persistence layer code to avoid doing seralization/deseralization.
Also related to #1531
How did you test it?
This is new separated code that is not hooked up with system yet. Tested in unit test.
Potential risks
No.
Is hotfix candidate?
No.