Emit dedicated metrics for context cancelled #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split ServiceErrContextTimeoutCounter metrics into ServiceErrContextTimeoutCounter and ServiceErrContextCancelledCounter * ServiceErrContextCancelledCounter metrics indicates request being cancelled * ServiceErrContextTimeoutCounter metrics indicates timeout
mastermanu
approved these changes
Jun 14, 2021
yiminc
approved these changes
Jun 14, 2021
alexshtin
approved these changes
Jun 14, 2021
wxing1292
added a commit
that referenced
this pull request
Jun 14, 2021
* Split ServiceErrContextTimeoutCounter metrics into ServiceErrContextTimeoutCounter and ServiceErrContextCancelledCounter * ServiceErrContextCancelledCounter metrics indicates request being cancelled * ServiceErrContextTimeoutCounter metrics indicates timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Use dedicated metrics for dedicated error.
Matching to matching task forwarding will return
*serviceerror.Canceledwhich will emitServiceErrContextCancelledCountermetricsref: https://github.com/temporalio/temporal/blob/v1.10.2/service/matching/taskQueueManager.go#L129
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A