Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unable to reset workflow issue #1673

Merged
merged 3 commits into from Jun 23, 2021
Merged

Fix unable to reset workflow issue #1673

merged 3 commits into from Jun 23, 2021

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Jun 23, 2021 •
edited

What changed?

  • Properly calculate lower / higher bound when reading each history branch, otherwise history event branch after fork operation can return more data than requested.

NOTE: this only affects reset workflow API when reset on already reset-ed workflow

Why?
Read higher bound of history branch is not calculated correctly:

  • the bug: the branch higher bound will be largest event ID within the branch
  • fix: the branch higher bound should be min(request last event ID, largest event ID within the branch)

How did you test it?
New tests

Potential risks
N/A

Is hotfix candidate?
Yes

@wxing1292 wxing1292 requested review from alexshtin, yiminc and a team June 23, 2021 19:00
@wxing1292 wxing1292 changed the title Fix read history branch upper limit issu Fix read history branch upper limit issue Jun 23, 2021
@wxing1292 wxing1292 changed the title Fix read history branch upper limit issue Fix unable to reset workflow issue Jun 23, 2021
@wxing1292 wxing1292 enabled auto-merge (squash) June 23, 2021 19:21
@wxing1292 wxing1292 merged commit a86f44e into temporalio:master Jun 23, 2021
@wxing1292 wxing1292 deleted the bugfix-fork-read-history branch June 23, 2021 19:40
wxing1292 added a commit that referenced this pull request Jun 23, 2021
@wxing1292
Fix unable to reset workflow issue (#1673)
35c5ff4 
* Properly calculate lower / higher bound when reading each history branch, otherwise history event branch after fork operation can return more data than requested.
wxing1292 added a commit that referenced this pull request Jun 23, 2021
@wxing1292
Fix unable to reset workflow issue (#1673)
7f3bea1 
* Properly calculate lower / higher bound when reading each history branch, otherwise history event branch after fork operation can return more data than requested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@alexshtin alexshtin Awaiting requested review from alexshtin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wxing1292 @yiminc