Fix ExecutionTime backfill by changing init order #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Aug 18, 2021
yiminc
approved these changes
Aug 18, 2021
yiminc
pushed a commit
that referenced
this pull request
Aug 18, 2021
yiminc
pushed a commit
that referenced
this pull request
Aug 19, 2021
Ardagan
added a commit
to Ardagan/temporal
that referenced
this pull request
Sep 21, 2021
…mporalio#1836)"" This reverts commit 15ed1b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Tweak the order of initializing fields so that the backfill
ExecutionTimelogic works correctly.Why?
It was calling
GetStartEventbefore initializingexecutionState, which contains the run id. Without the run id, the event cache was using a bad key and confusing events from different runs.How did you test it?
Mostly manual testing and observation.
Potential risks
This only affects the
ExecutionTimebackfill logic, so shouldn't affect anything that doesn't depend on that.Is hotfix candidate?
yes