Paul MS cache update #1887
Merged
Paul MS cache update #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
make LRU pinning API no-op for non-pinned caches make sure all operations on zero-size cache are sane
mmcshane
approved these changes
Sep 3, 2021
alexshtin
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Ensure cache operations are no-ops for uncached objects; make sure zero-size cache behaves.
Why?
How did you test it?
added unit test
Potential risks
errors here would be very troublesome to History Service, Matching, other users (if any) of lru cache.
Is hotfix candidate?
No