Create admin API to get task queue tasks #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Nov 23, 2021
| @@ -360,3 +362,16 @@ message ResendReplicationTasksRequest { | |||
|
|
|||
| message ResendReplicationTasksResponse { | |||
| } | |||
|
|
|||
| message GetTaskQueueTasksRequest { | |||
There was a problem hiding this comment.
GetTaskQueueTasksRequest -> ListTaskQueueTasksRequest & add a pagination token?
There was a problem hiding this comment.
afaict this also requires changes in persistence right so it returns a page token? i'm opening a ticket for refactoring
yiminc
reviewed
Nov 23, 2021
| @@ -360,3 +362,16 @@ message ResendReplicationTasksRequest { | |||
|
|
|||
| message ResendReplicationTasksResponse { | |||
| } | |||
|
|
|||
| message GetTaskQueueTasksRequest { | |||
| string namespace_id = 1; | |||
There was a problem hiding this comment.
I think we should use namespace.
feedmeapples
force-pushed
the
admin-api-tq-list-tasks
branch
from
243fd24
to
0a7f1d1
Compare
feedmeapples
force-pushed
the
admin-api-tq-list-tasks
branch
from
0a7f1d1
to
7077aab
Compare
yiminc
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Created an admin API that that allows to get task-queue tasks
Why?
simplifie get task queue tasks in tctl admin command by removing the need for direct DB connection params
How did you test it?
./tctl admin taskqueue list_tasks --namespace default --taskqueue open-n-closedPotential risks
adds a new API, no risks for existing functionality
Is hotfix candidate?