Split lease task queue API into 2 #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
review #2262 first |
wxing1292
force-pushed
the
what-why-how
branch
3 times, most recently
from
1ecafb3
to
4f5d063
Compare
* Split matching persistence LeaseTaskQueue API into * CreateTaskQueue * GetTaskQueue * Add new task queue UT * Add new task queue task UT * Deprecate legacy matching task tests
wxing1292
force-pushed
the
what-why-how
branch
from
4f5d063
to
0943871
Compare
wxing1292
changed the title
yiminc
reviewed
Dec 10, 2021
| @@ -67,6 +67,10 @@ import ( | |||
| "go.temporal.io/server/service/history/tasks" | |||
| ) | |||
|
|
|||
| // TimePrecision is needed to account for database timestamp precision. | |||
| // Cassandra only provides milliseconds timestamp precision, so we need to use tolerance when doing comparison | |||
| const TimePrecision = 2 * time.Millisecond | |||
There was a problem hiding this comment.
this is not used anywhere in this PR?
There was a problem hiding this comment.
it is used by existing persistence tests, simply moving the definition from file to be deleted to here
yiminc
approved these changes
Dec 11, 2021
| taskQueue := &taskqueuepb.TaskQueue{Name: tl} | ||
| taskQueue := &taskqueuepb.TaskQueue{ | ||
| Name: tl, | ||
| Kind: enumspb.TASK_QUEUE_KIND_NORMAL, |
There was a problem hiding this comment.
the Unspecified should be treated as Normal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Code cleanup & test cleanup
How did you test it?
New tests
Potential risks
N/A
Is hotfix candidate?
No