Log build CGO_ENABLED state #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Feb 15, 2022
cmd/server/main.go
Outdated
| @@ -47,6 +47,10 @@ import ( | |||
| "go.temporal.io/server/temporal" | |||
| ) | |||
|
|
|||
| var ( | |||
| cgoEnabled = false | |||
There was a problem hiding this comment.
Just a few lines bellow.
There was a problem hiding this comment.
I'm not sure I follow. Line 146 uses build.InfoData.CgoEnabled which is either defined in cgo.go or nocgo.go. I don't see where this valuable is used.
There was a problem hiding this comment.
Sorry, @yiminc. It is leftover from 1st implementation. Thanks for catching this!
alexshtin
force-pushed
the
feature/log-cgo-state
branch
from
b8135be
to
298ef03
Compare
alexshtin
force-pushed
the
feature/log-cgo-state
branch
from
403c936
to
929734d
Compare
yiminc
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Log build
CGO_ENABLEDstate.Why?
For better debugging issues which are related to
cgoit is very useful to know ifcgowas enabled during build or not.How did you test it?
Run locally.
Potential risks
No risks.
Is hotfix candidate?
No.