Add tag support to sdkLogger #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/sdk-logger-tag-support
branch
2 times, most recently
from
ef200cf
to
833fd5c
Compare
alexshtin
force-pushed
the
feature/sdk-logger-tag-support
branch
from
833fd5c
to
4629842
Compare
yiminc
approved these changes
Feb 16, 2022
common/log/sdk_logger.go
Outdated
| tags = append(tags, tag.NewAnyTag(key, keyvals[i+1])) | ||
| var val interface{} | ||
| if i+1 == len(keyvals) { | ||
| val = fmt.Sprintf("last key %q doesn't have value", key) |
There was a problem hiding this comment.
Just use a const string as value is enough, for example no value. The key is on the tag anyway.
There was a problem hiding this comment.
It should never happen, but I like the idea, in case if you want to log just a key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add
tagsupport tosdkLogger.Also accidentally updated submodules.
Why?
To improve logging experience from internal workflows. Now it is possible to use internal
tag.Tagwith workflow logger.How did you test it?
Added new unit tests.
Potential risks
No risks.
Is hotfix candidate?
No.