Add SetWorkflowExecution persistence API #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add SetWorkflowExecution persistence API for allow overwriting a mutable state * Update tests
yiminc
approved these changes
Feb 19, 2022
Comment on lines
+996
to
+997
| // dbVersion is for CAS, so the db record version will be set to `resetWorkflow.DBRecordVersion` | ||
| // while CAS on `resetWorkflow.DBRecordVersion - 1` |
There was a problem hiding this comment.
update comment to not use resetWorkflow?
| batch := d.Session.NewBatch(gocql.LoggedBatch) | ||
|
|
||
| shardID := request.ShardID | ||
| workflow := request.SetWorkflowSnapshot |
There was a problem hiding this comment.
nit: i would use snapshot as this local variable name.
There was a problem hiding this comment.
the GitHub phone app collapse the review comments so did not notice this after merging the PR, will address the comments in the next PR
| @@ -75,7 +75,7 @@ func applyWorkflowMutationTx( | |||
| workflowMutation.DBRecordVersion, | |||
| ); err != nil { | |||
| switch err.(type) { | |||
| case *p.WorkflowConditionFailedError: | |||
| case *p.WorkflowConditionFailedError, *p.ConditionFailedError: | |||
There was a problem hiding this comment.
Not a big issue, only the returned error type is not expected.
paulnpdev
reviewed
Feb 19, 2022
| request.RangeID, | ||
| ) | ||
|
|
||
| conflictRecord := make(map[string]interface{}) |
There was a problem hiding this comment.
this is actually one row, the iter can return other rows if multiple rows are involved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
More functionality
How did you test it?
New tests
Potential risks
N/A
Is hotfix candidate?
No