Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor persistence factory implementation #2544

Merged
merged 4 commits into from Feb 28, 2022
Merged

Refactor persistence factory implementation #2544

merged 4 commits into from Feb 28, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Feb 24, 2022

What changed?

  • Remove FaultInjection from persistence factory interface
  • Add provider for data store factory and fault injection data store factory
  • Use one data store factory for all store types

Why?

  • Don't have to duplicate code for creating data store factory

How did you test it?

  • Existing test

Potential risks

Is hotfix candidate?

@yycptt yycptt requested review from yux0 and yiminc February 24, 2022 23:01
@yycptt yycptt requested a review from a team as a code owner February 24, 2022 23:01
@yycptt yycptt merged commit 3b07030 into temporalio:master Feb 28, 2022
@yycptt yycptt deleted the refactor-pfactory branch February 28, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@yux0 yux0 Awaiting requested review from yux0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yycptt @yiminc