Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor persistence task serializer #2555

Merged
merged 1 commit into from Feb 28, 2022
Merged

Refactor persistence task serializer #2555

merged 1 commit into from Feb 28, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Feb 26, 2022 •
edited

What changed?

  • Refactor persistence task serializer to serialize/deserialize one task at a time

Why?

  • Address a TODO in code to avoid unnecessary conversion between map[tasks.Key]common.DataBlob and []p.InternalHistoryTask

How did you test it?
Existing tests

Potential risks

Is hotfix candidate?
no

@yycptt yycptt requested a review from yux0 February 26, 2022 00:20
@yycptt yycptt requested a review from a team as a code owner February 26, 2022 00:20
@yycptt yycptt merged commit 4c38108 into temporalio:master Feb 28, 2022
@yycptt yycptt deleted the refactor-task-serializer branch February 28, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yycptt @yux0 @yiminc