Add dynamic config for per instance visibility API rate limit #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you plz take a look at this example? i believe this might be better |
yiminc
reviewed
Mar 8, 2022
common/dynamicconfig/constants.go
Outdated
| @@ -152,6 +152,8 @@ const ( | |||
| FrontendMaxNamespaceBurstPerInstance = "frontend.namespaceBurst" | |||
| // FrontendMaxNamespaceCountPerInstance is workflow namespace count limit per second | |||
| FrontendMaxNamespaceCountPerInstance = "frontend.namespaceCount" | |||
| // FrontendMaxVisibilityNamespaceRPSPerInstance is namespace rate limit per second for visibility APIs | |||
| FrontendMaxVisibilityNamespaceRPSPerInstance = "frontend.visibilityNamespaceRPS" | |||
There was a problem hiding this comment.
how about frontend.namespaceRPS.visibility ?
yiminc
reviewed
Mar 8, 2022
Comment on lines
71
to
80
| testGetIntPropertyFilteredByNamespaceApiTypeKey: | ||
| - value: 30 | ||
| constraints: {} | ||
| - value: 20 | ||
| constraints: | ||
| namespace: samples-namespace | ||
| - value: 10 | ||
| constraints: | ||
| namespace: samples-namespace | ||
| apiType: visibility |
There was a problem hiding this comment.
can you set a default RPS for visibility to 10 for all namespace?
wxing1292
approved these changes
Mar 8, 2022
meiliang86
force-pushed
the
visiblity-rate-limit-2
branch
from
c494237
to
5c511a8
Compare
meiliang86
force-pushed
the
visiblity-rate-limit-2
branch
from
5c511a8
to
eafe2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add dynamic config for per instance visibility API rate limit
Why?
Service protection.
How did you test it?
Existing tests?
Potential risks
rate limits are set wrong and frontend calls are accepted or rejected wrongfully
Is hotfix candidate?
Yes