Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle delete history branch #2591

Merged
merged 8 commits into from Mar 8, 2022
Merged

Handle delete history branch #2591

merged 8 commits into from Mar 8, 2022

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Mar 8, 2022

What changed?
Handle delete history branch when mutable state does not exist

Why?
Handle two cases:

  1. ms is gone. We should try to delete the history branch.
  2. version check failed. We should try to delete the history branch.

With this, the task can be retried and only delete the leftover history data.

How did you test it?

Potential risks

Is hotfix candidate?

service/history/timerQueueActiveTaskExecutor.go Outdated Show resolved Hide resolved
service/history/timerQueueTaskExecutorBase.go Outdated Show resolved Hide resolved
service/history/timerQueueTaskExecutorBase.go Outdated Show resolved Hide resolved
service/history/timerQueueTaskExecutorBase.go Outdated Show resolved Hide resolved
service/history/timerQueueTaskExecutorBase.go Outdated Show resolved Hide resolved
@yux0 yux0 requested review from yycptt and alexshtin March 8, 2022 22:47
service/history/nDCTaskUtil.go Outdated Show resolved Hide resolved
service/history/timerQueueTaskExecutorBase.go Outdated Show resolved Hide resolved
service/history/timerQueueTaskExecutorBase.go Outdated Show resolved Hide resolved
service/history/timerQueueTaskExecutorBase.go Outdated Show resolved Hide resolved
@yux0 yux0 marked this pull request as ready for review March 8, 2022 23:24
@yux0 yux0 requested a review from a team as a code owner March 8, 2022 23:24
@yux0 yux0 merged commit 4375f94 into temporalio:master Mar 8, 2022
@yux0 yux0 deleted the delete-task branch March 8, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants