Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated admin list tasks APIs #2592

Merged
merged 1 commit into from Mar 9, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 8, 2022

What changed?
Remove deprecated admin ListTransfer/Timer/Replication/VisibilityTasks.
tctl should use the new admin ListHistoryTasks API.

  • NOTE: there's no backward compatible issue here since the current tctl implementation for listing those tasks are broken and it will always return an empty result (because batch size parameter is never populated, for transfer/replication/visibility tasks, both min/max taskID are also empty). So no tctl user will be broken by this change.

Why?
Deprecated admin ListTransfer/Timer/Replication/VisibilityTasks
#2580 (comment)

How did you test it?
N/A, remove code

Potential risks
N/A

Is hotfix candidate?
no

@yycptt yycptt requested a review from yiminc March 8, 2022 21:26
@yycptt yycptt requested a review from a team as a code owner March 8, 2022 21:26
@yycptt yycptt merged commit 1e3bc68 into temporalio:master Mar 9, 2022
@yycptt yycptt deleted the remove-admin-list-tasks branch March 9, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants