Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit estimated matching task lag metric #2605

Merged
merged 2 commits into from Mar 14, 2022
Merged

Emit estimated matching task lag metric #2605

merged 2 commits into from Mar 14, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 11, 2022

What changed?

  • Emit estimated matching task lag metric
  • Add task queue type tag for metrics emitted by matching task queue manager as activity and workflow task queue can have the same name.

Why?

  • Estimate task lag.

How did you test it?
Existing tests.

Potential risks
Dashboard may need to be updated to use the new tag.

Is hotfix candidate?
no

@yycptt yycptt requested a review from yiminc March 11, 2022 20:29
@yycptt yycptt requested a review from a team as a code owner March 11, 2022 20:29
@yycptt yycptt merged commit 9732f77 into temporalio:master Mar 14, 2022
@yycptt yycptt deleted the matching-task-lag-metric branch March 14, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yycptt @yiminc