Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove replication start event sanity check #2616

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Remove replication start event sanity check #2616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions service/frontend/adminHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1494,11 +1494,6 @@ func (adh *AdminHandler) validateGetWorkflowExecutionRawHistoryV2Request(
return errInvalidEventQueryRange
}

if (request.GetStartEventId() != common.EmptyEventID && request.GetStartEventVersion() == common.EmptyVersion) ||
(request.GetStartEventId() == common.EmptyEventID && request.GetStartEventVersion() != common.EmptyVersion) {
return errInvalidStartEventCombination
}

return nil
}

Expand Down
2 changes: 0 additions & 2 deletions service/frontend/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ var (
errInvalidPageSize = serviceerror.NewInvalidArgument("Invalid PageSize.")
errInvalidPaginationToken = serviceerror.NewInvalidArgument("Invalid pagination token.")
errInvalidFirstNextEventCombination = serviceerror.NewInvalidArgument("Invalid FirstEventId and NextEventId combination.")
errInvalidStartEventCombination = serviceerror.NewInvalidArgument("Invalid StartEventId and StartEventVersion combination.")
errInvalidEndEventCombination = serviceerror.NewInvalidArgument("Invalid EndEventId and EndEventVersion combination.")
errInvalidVersionHistories = serviceerror.NewInvalidArgument("Invalid version histories.")
errInvalidEventQueryRange = serviceerror.NewInvalidArgument("Invalid event query range.")
errDLQTypeIsNotSupported = serviceerror.NewInvalidArgument("The DLQ type is not supported.")
Expand Down