Handle activity retry timer in passive #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Mar 24, 2022
| @@ -144,7 +144,7 @@ func (t *transferQueueStandbyTaskExecutor) processActivityTask( | |||
| } | |||
|
|
|||
| if activityInfo.StartedId == common.EmptyEventID { | |||
| return newPushActivityToMatchingInfo(*activityInfo.ScheduleToStartTimeout), nil | |||
| return newPushActivityToMatchingInfo(activityInfo.TaskQueue, *activityInfo.ScheduleToStartTimeout), nil | |||
There was a problem hiding this comment.
so activityInfo.TaskQueue always equals to task.TaskQueue? Do you happen to know why we persist the field in transfer tasks in the first place?
There was a problem hiding this comment.
Updated to task.TaskQueue
| return nil, nil | ||
| } | ||
|
|
||
| if activityInfo.Attempt > task.Attempt { |
There was a problem hiding this comment.
I realize we have the same thing in timer active execution. But I am curious why we use > instead of ==?
yycptt
reviewed
Mar 25, 2022
yycptt
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Handle activity retry timer in passive
Why?
Case: activity is retrying in source cluster and then failover to target cluster. We should persist the retry timer and handle the timer correctly.
How did you test it?
Unit tests
Potential risks
Is hotfix candidate?