Add scheduler time logic #2666
Merged
Add scheduler time logic #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
May 3, 2022
| compiledCalendar struct { | ||
| tz *time.Location | ||
|
|
||
| year, month, dayOfMonth, dayOfWeek, hour, minute, second func(int) bool |
There was a problem hiding this comment.
what is the input int and what is output bool?
service/worker/scheduler/calendar.go
Outdated
Comment on lines
56
to
58
| parseModeInt parseMode = iota | ||
| parseModeMonth | ||
| parseModeDow |
| }, nil | ||
| } | ||
|
|
||
| func parseStringSpec(s string, min, max int, parseMode parseMode, f func(int)) error { |
There was a problem hiding this comment.
need comments on what are the expected specs.
would be good to put some input example to help reader understand this code
| after time.Time, | ||
| ) (nominal, next time.Time, has bool) { | ||
| if cs.spec.StartTime != nil && after.Before(*cs.spec.StartTime) { | ||
| after = cs.spec.StartTime.Add(-time.Second) |
yiminc
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add logic to implement schedule specs in temporalio/api#157
Why?
To be used by new scheduler service
How did you test it?
unit tests
Potential risks
nothing yet