Fix history client NPE for invalid shardID #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
commented
Mar 30, 2022
| } | ||
| opts ...grpc.CallOption, | ||
| ) (*historyservice.RemoveTaskResponse, error) { | ||
| client, err := c.getClientForShardID(request.GetShardId()) |
There was a problem hiding this comment.
getClientForShardID will check if shardID <= 0 and return an invalid argument error.
yiminc
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
clientwill not be initialized but still be used to make the rpc call, result in an NPE error.How did you test it?
Potential risks
Is hotfix candidate?