Use better retry logic in reclaimresources workflow #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Use better retry logic in
reclaimresourcesworkflow.Why?
When advanced visibility is enabled,
EnsureNoExecutionActivityuses better retry logic now. Instead of just retrying for some period of time, it monitors progress of task processing. If progress is made then it keeps waiting. In case if no progress is made activity returns non-retryable error and workflow tries to delete executions again.Standard visibility just retries for 30 minutes making approximately 20 attempts.
How did you test it?
Modified unit tests and local run.
Potential risks
No risks.
Is hotfix candidate?
No.