buffer event as local namespace after promotion #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Apr 1, 2022
wxing1292
approved these changes
Apr 1, 2022
mastermanu
pushed a commit
that referenced
this pull request
Apr 4, 2022
* Pretend local namespace after ns promotion if there is inflight workflow task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretend namespace is still local after it is promoted if there is inflight workflow task.
Why?
So event will be buffered as local event while there is inflight workflow task
How did you test it?
New integration test. Without this fix, the new case would fail on error "event version must be the same inside a batch"
Potential risks
Is hotfix candidate?