Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistence context Part 7: SQL store implementation #2711

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Persistence context Part 7: SQL store implementation #2711

merged 1 commit into from
Apr 13, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Apr 11, 2022

What changed?

  • Use passed in context for sql persistence store impl

Why?

  • Enforce persistence timeout, instead of always timeout after 8s
  • Required for host level task worker pool

How did you test it?

  • Existing test

Potential risks

  • We may see an increased number of persistence context timeout error as now a lower context timeout will be used.

Is hotfix candidate?

  • No.

@yycptt yycptt requested a review from a team as a code owner April 11, 2022 18:35
@yycptt yycptt merged commit 2e55dd3 into temporalio:master Apr 13, 2022
@yycptt yycptt deleted the persistence-ctx-sql branch April 13, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yycptt @wxing1292 @yiminc