Use caller object as callback listener ID #2734
Conversation
There was a problem hiding this comment.
why not change the key to any and use the object itself as the key? (I made the same comment here: #2733 (comment))
Make sense |
|
You might want to update the title of the PR as you are not using UUID anymore. |
yux0
changed the title
| @@ -130,7 +130,7 @@ type ( | |||
| versionToClusterName map[int64]string | |||
|
|
|||
| clusterCallbackLock sync.RWMutex | |||
| clusterChangeCallback map[string]CallbackFn | |||
| clusterChangeCallback map[any]CallbackFn | |||
There was a problem hiding this comment.
it need to be comparable. not sure any would work.
There was a problem hiding this comment.
I believe any here is an alias for interface{} which is a type name and comparable. comparable is a constraint which doesn't work here (can't be used as a type name).
There was a problem hiding this comment.
@yycptt is right. And it works here as it uses the struct pointer as key.
* Use struct as callback listener ID
What changed?
Use UUID as callback listener ID
Why?
Race conditional may happen if a new shard starts before the old one close
How did you test it?
Use current unit tests
Potential risks
Is hotfix candidate?