Task priority assigner implementation #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
commented
Apr 19, 2022
wxing1292
reviewed
Apr 19, 2022
| namespaceName string, | ||
| ) quotas.RateLimiter { | ||
| a.RLock() | ||
| rateLimiter, ok := a.rateLimiters[namespaceName] |
There was a problem hiding this comment.
i would prefer namespace UUID
There was a problem hiding this comment.
I think using namespace name will be more friendly to the operator when tuning the rps limit. And since we need to access the namespace registry anyway to check if the namespace is active or not, the conversion from ID to name doesn't have an extra cost.
Let me know if you have strong opinion on this and we can sync offline.
wxing1292
approved these changes
Apr 19, 2022
yiminc
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?
No.