Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding error type tag to peristence errors #2748

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Adding error type tag to peristence errors #2748

merged 1 commit into from
Apr 21, 2022

Conversation

jbreiding
Copy link
Contributor

@jbreiding jbreiding commented Apr 20, 2022

What changed?
Adding error type tag to persistence failures metric

Why?
Follow on to #2741

How did you test it?
Locally, I am good at errors

Potential risks
Metric tagging differences

Is hotfix candidate?
No

metrics

# HELP persistence_errors persistence_errors counter
# TYPE persistence_errors counter
persistence_errors{error_type="serviceerror_NotFound",namespace="all",operation="GetCurrentExecution",service_name="history"} 1
persistence_errors{error_type="serviceerror_NotFound",namespace="all",operation="GetNamespace",service_name="frontend"} 2
persistence_errors{error_type="serviceerror_NotFound",namespace="all",operation="GetTaskQueue",service_name="matching"} 32
# HELP persistence_errors_entity_not_exists persistence_errors_entity_not_exists counter
# TYPE persistence_errors_entity_not_exists counter
persistence_errors_entity_not_exists{namespace="all",operation="GetCurrentExecution",service_name="history"} 1
persistence_errors_entity_not_exists{namespace="all",operation="GetNamespace",service_name="frontend"} 2
persistence_errors_entity_not_exists{namespace="all",operation="GetTaskQueue",service_name="matching"} 32

@jbreiding jbreiding requested a review from a team as a code owner April 20, 2022 14:35
@jbreiding jbreiding enabled auto-merge (squash) April 20, 2022 15:12
@jbreiding jbreiding merged commit 04ac068 into temporalio:master Apr 21, 2022
@jbreiding jbreiding deleted the error-type-persistence-failure-metric branch April 21, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider report all service_errors as one metric with error type as tag
2 participants