Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UI as a client in version checker #2751

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Support UI as a client in version checker #2751

merged 1 commit into from
Apr 28, 2022

Conversation

feedmeapples
Copy link
Contributor

What changed?

Added UI as a client in version checker

Why?

allows UI to pass the version to Temporal

How did you test it?

Verified that the UI requests still pass and version checker doesn't throw unsupported version error

Potential risks

Is hotfix candidate?

@feedmeapples feedmeapples requested a review from a team as a code owner April 20, 2022 22:35
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feedmeapples feedmeapples enabled auto-merge (squash) April 28, 2022 00:24
@feedmeapples feedmeapples merged commit 6ff2f59 into master Apr 28, 2022
@feedmeapples feedmeapples deleted the support-ui branch April 28, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants